aio: Fix an error code in __io_submit_one()

Dan Carpenter · Al Viro · commit 18bfb9c6a8a5 · 2019-04-03T12:47:36.000-04:00
This accidentally returns the wrong variable. The "req->ki_eventfd" pointer is NULL so this return success. Fixes: 7316b49 ("aio: move sanity checks and request allocation to io_submit_one()") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
diff --git a/fs/aio.c b/fs/aio.c
@@ -1794,7 +1794,7 @@ static int __io_submit_one(struct kioctx *ctx, const struct iocb *iocb,
 		 */
 		eventfd = eventfd_ctx_fdget(iocb->aio_resfd);
 		if (IS_ERR(eventfd))
-			return PTR_ERR(req->ki_eventfd);
+			return PTR_ERR(eventfd);
 
 		req->ki_eventfd = eventfd;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1794,7 +1794,7 @@ static int __io_submit_one(struct kioctx ctx, const struct iocb iocb,`
`1794`	`1794`	`*/`
`1795`	`1795`	`eventfd = eventfd_ctx_fdget(iocb->aio_resfd);`
`1796`	`1796`	`if (IS_ERR(eventfd))`
`1797`		`- return PTR_ERR(req->ki_eventfd);`
	`1797`	`+ return PTR_ERR(eventfd);`
`1798`	`1798`
`1799`	`1799`	`req->ki_eventfd = eventfd;`
`1800`	`1800`	`}`