Skip to content

Commit 18da755

Browse files
jbeptxjic23
authored andcommitted
Staging/iio/adc/touchscreen/MXS: add proper clock handling
The delay units inside the LRADC depend on the presence of a 2 kHz clock. This change enables the clock to be able to use the delay unit for the touchscreen part of the driver. Signed-off-by: Juergen Beisert <jbe@pengutronix.de> Tested-by: Marek Vasut <marex@denx.de> Acked-by: Marek Vasut <marex@denx.de> Tested-by: Lothar Waßmann <LW@KARO-electronics.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
1 parent dd28e48 commit 18da755

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

arch/arm/boot/dts/imx23.dtsi

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,7 @@
430430
reg = <0x80050000 0x2000>;
431431
interrupts = <36 37 38 39 40 41 42 43 44>;
432432
status = "disabled";
433+
clocks = <&clks 26>;
433434
};
434435

435436
spdif@80054000 {

arch/arm/boot/dts/imx28.dtsi

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -902,6 +902,7 @@
902902
interrupts = <10 14 15 16 17 18 19
903903
20 21 22 23 24 25>;
904904
status = "disabled";
905+
clocks = <&clks 41>;
905906
};
906907

907908
spdif: spdif@80054000 {

drivers/staging/iio/adc/mxs-lradc.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
#include <linux/completion.h>
3636
#include <linux/delay.h>
3737
#include <linux/input.h>
38+
#include <linux/clk.h>
3839

3940
#include <linux/iio/iio.h>
4041
#include <linux/iio/buffer.h>
@@ -134,6 +135,8 @@ struct mxs_lradc {
134135
void __iomem *base;
135136
int irq[13];
136137

138+
struct clk *clk;
139+
137140
uint32_t *buffer;
138141
struct iio_trigger *trig;
139142

@@ -922,6 +925,17 @@ static int mxs_lradc_probe(struct platform_device *pdev)
922925
if (IS_ERR(lradc->base))
923926
return PTR_ERR(lradc->base);
924927

928+
lradc->clk = devm_clk_get(&pdev->dev, NULL);
929+
if (IS_ERR(lradc->clk)) {
930+
dev_err(dev, "Failed to get the delay unit clock\n");
931+
return PTR_ERR(lradc->clk);
932+
}
933+
ret = clk_prepare_enable(lradc->clk);
934+
if (ret != 0) {
935+
dev_err(dev, "Failed to enable the delay unit clock\n");
936+
return ret;
937+
}
938+
925939
INIT_WORK(&lradc->ts_work, mxs_lradc_ts_work);
926940

927941
/* Check if touchscreen is enabled in DT. */
@@ -1014,6 +1028,7 @@ static int mxs_lradc_remove(struct platform_device *pdev)
10141028
mxs_lradc_trigger_remove(iio);
10151029
iio_triggered_buffer_cleanup(iio);
10161030

1031+
clk_disable_unprepare(lradc->clk);
10171032
return 0;
10181033
}
10191034

0 commit comments

Comments
 (0)