Skip to content

Commit 1a512c0

Browse files
arndbKAGA-KOKO
arndb
authored and
KAGA-KOKO
committed
x86/ipc: Fix x32 version of shmid64_ds and msqid64_ds
A bugfix broke the x32 shmid64_ds and msqid64_ds data structure layout (as seen from user space) a few years ago: Originally, __BITS_PER_LONG was defined as 64 on x32, so we did not have padding after the 64-bit __kernel_time_t fields, After __BITS_PER_LONG got changed to 32, applications would observe extra padding. In other parts of the uapi headers we seem to have a mix of those expecting either 32 or 64 on x32 applications, so we can't easily revert the path that broke these two structures. Instead, this patch decouples x32 from the other architectures and moves it back into arch specific headers, partially reverting the even older commit 73a2d09 ("x86: remove all now-duplicate header files"). It's not clear whether this ever made any difference, since at least glibc carries its own (correct) copy of both of these header files, so possibly no application has ever observed the definitions here. Based on a suggestion from H.J. Lu, I tried out the tool from https://github.com/hjl-tools/linux-header to find other such bugs, which pointed out the same bug in statfs(), which also has a separate (correct) copy in glibc. Fixes: f4b4aae ("x86/headers/uapi: Fix __BITS_PER_LONG value for x32 builds") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: "H . J . Lu" <hjl.tools@gmail.com> Cc: Jeffrey Walton <noloader@gmail.com> Cc: stable@vger.kernel.org Cc: "H. Peter Anvin" <hpa@zytor.com> Link: https://lkml.kernel.org/r/20180424212013.3967461-1-arnd@arndb.de
1 parent 3db3eb2 commit 1a512c0

File tree

2 files changed

+73
-0
lines changed

2 files changed

+73
-0
lines changed

‎arch/x86/include/uapi/asm/msgbuf.h

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,32 @@
1+
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
2+
#ifndef __ASM_X64_MSGBUF_H
3+
#define __ASM_X64_MSGBUF_H
4+
5+
#if !defined(__x86_64__) || !defined(__ILP32__)
16
#include <asm-generic/msgbuf.h>
7+
#else
8+
/*
9+
* The msqid64_ds structure for x86 architecture with x32 ABI.
10+
*
11+
* On x86-32 and x86-64 we can just use the generic definition, but
12+
* x32 uses the same binary layout as x86_64, which is differnet
13+
* from other 32-bit architectures.
14+
*/
15+
16+
struct msqid64_ds {
17+
struct ipc64_perm msg_perm;
18+
__kernel_time_t msg_stime; /* last msgsnd time */
19+
__kernel_time_t msg_rtime; /* last msgrcv time */
20+
__kernel_time_t msg_ctime; /* last change time */
21+
__kernel_ulong_t msg_cbytes; /* current number of bytes on queue */
22+
__kernel_ulong_t msg_qnum; /* number of messages in queue */
23+
__kernel_ulong_t msg_qbytes; /* max number of bytes on queue */
24+
__kernel_pid_t msg_lspid; /* pid of last msgsnd */
25+
__kernel_pid_t msg_lrpid; /* last receive pid */
26+
__kernel_ulong_t __unused4;
27+
__kernel_ulong_t __unused5;
28+
};
29+
30+
#endif
31+
32+
#endif /* __ASM_GENERIC_MSGBUF_H */

‎arch/x86/include/uapi/asm/shmbuf.h

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,43 @@
1+
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
2+
#ifndef __ASM_X86_SHMBUF_H
3+
#define __ASM_X86_SHMBUF_H
4+
5+
#if !defined(__x86_64__) || !defined(__ILP32__)
16
#include <asm-generic/shmbuf.h>
7+
#else
8+
/*
9+
* The shmid64_ds structure for x86 architecture with x32 ABI.
10+
*
11+
* On x86-32 and x86-64 we can just use the generic definition, but
12+
* x32 uses the same binary layout as x86_64, which is differnet
13+
* from other 32-bit architectures.
14+
*/
15+
16+
struct shmid64_ds {
17+
struct ipc64_perm shm_perm; /* operation perms */
18+
size_t shm_segsz; /* size of segment (bytes) */
19+
__kernel_time_t shm_atime; /* last attach time */
20+
__kernel_time_t shm_dtime; /* last detach time */
21+
__kernel_time_t shm_ctime; /* last change time */
22+
__kernel_pid_t shm_cpid; /* pid of creator */
23+
__kernel_pid_t shm_lpid; /* pid of last operator */
24+
__kernel_ulong_t shm_nattch; /* no. of current attaches */
25+
__kernel_ulong_t __unused4;
26+
__kernel_ulong_t __unused5;
27+
};
28+
29+
struct shminfo64 {
30+
__kernel_ulong_t shmmax;
31+
__kernel_ulong_t shmmin;
32+
__kernel_ulong_t shmmni;
33+
__kernel_ulong_t shmseg;
34+
__kernel_ulong_t shmall;
35+
__kernel_ulong_t __unused1;
36+
__kernel_ulong_t __unused2;
37+
__kernel_ulong_t __unused3;
38+
__kernel_ulong_t __unused4;
39+
};
40+
41+
#endif
42+
43+
#endif /* __ASM_X86_SHMBUF_H */

0 commit comments

Comments
 (0)