Skip to content

Commit 1a7a670

Browse files
storulfrafaeljw
authored andcommitted
PM / Domains: Drop __pm_genpd_add_device()
There are still a few non-DT existing users of genpd, however neither of them uses __pm_genpd_add_device(), hence let's drop it. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 781b9d6 commit 1a7a670

File tree

2 files changed

+7
-17
lines changed

2 files changed

+7
-17
lines changed

drivers/base/power/domain.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1414,23 +1414,21 @@ static int genpd_add_device(struct generic_pm_domain *genpd, struct device *dev,
14141414
}
14151415

14161416
/**
1417-
* __pm_genpd_add_device - Add a device to an I/O PM domain.
1417+
* pm_genpd_add_device - Add a device to an I/O PM domain.
14181418
* @genpd: PM domain to add the device to.
14191419
* @dev: Device to be added.
1420-
* @td: Set of PM QoS timing parameters to attach to the device.
14211420
*/
1422-
int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev,
1423-
struct gpd_timing_data *td)
1421+
int pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev)
14241422
{
14251423
int ret;
14261424

14271425
mutex_lock(&gpd_list_lock);
1428-
ret = genpd_add_device(genpd, dev, td);
1426+
ret = genpd_add_device(genpd, dev, NULL);
14291427
mutex_unlock(&gpd_list_lock);
14301428

14311429
return ret;
14321430
}
1433-
EXPORT_SYMBOL_GPL(__pm_genpd_add_device);
1431+
EXPORT_SYMBOL_GPL(pm_genpd_add_device);
14341432

14351433
static int genpd_remove_device(struct generic_pm_domain *genpd,
14361434
struct device *dev)

include/linux/pm_domain.h

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,7 @@ static inline struct generic_pm_domain_data *dev_gpd_data(struct device *dev)
143143
return to_gpd_data(dev->power.subsys_data->domain_data);
144144
}
145145

146-
int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev,
147-
struct gpd_timing_data *td);
146+
int pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev);
148147
int pm_genpd_remove_device(struct generic_pm_domain *genpd, struct device *dev);
149148
int pm_genpd_add_subdomain(struct generic_pm_domain *genpd,
150149
struct generic_pm_domain *new_subdomain);
@@ -163,9 +162,8 @@ static inline struct generic_pm_domain_data *dev_gpd_data(struct device *dev)
163162
{
164163
return ERR_PTR(-ENOSYS);
165164
}
166-
static inline int __pm_genpd_add_device(struct generic_pm_domain *genpd,
167-
struct device *dev,
168-
struct gpd_timing_data *td)
165+
static inline int pm_genpd_add_device(struct generic_pm_domain *genpd,
166+
struct device *dev)
169167
{
170168
return -ENOSYS;
171169
}
@@ -204,12 +202,6 @@ static inline int dev_pm_genpd_set_performance_state(struct device *dev,
204202
#define pm_domain_always_on_gov (*(struct dev_power_governor *)(NULL))
205203
#endif
206204

207-
static inline int pm_genpd_add_device(struct generic_pm_domain *genpd,
208-
struct device *dev)
209-
{
210-
return __pm_genpd_add_device(genpd, dev, NULL);
211-
}
212-
213205
#ifdef CONFIG_PM_GENERIC_DOMAINS_SLEEP
214206
void pm_genpd_syscore_poweroff(struct device *dev);
215207
void pm_genpd_syscore_poweron(struct device *dev);

0 commit comments

Comments
 (0)