hv_netvsc: make const array ver_list static, reduces object code size

Colin Ian King · davem330 · commit 1b17ca044a82 · 2017-09-25T16:25:17.000-07:00
Don't populate const array ver_list on the stack, instead make it
static. Makes the object code smaller by over 400 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  18444	   3168	    320	  21932	   55ac	drivers/net/hyperv/netvsc.o

After:
   text	   data	    bss	    dec	    hex	filename
  17950	   3224	    320	  21494	   53f6	drivers/net/hyperv/netvsc.o

(gcc 6.3.0, x86-64)

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Reviewed-by: Haiyang Zhang &lt;haiyangz@microsoft.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
@@ -484,7 +484,7 @@ static int netvsc_connect_vsp(struct hv_device *device,
 			      struct netvsc_device *net_device,
 			      const struct netvsc_device_info *device_info)
 {
-	const u32 ver_list[] = {
+	static const u32 ver_list[] = {
 		NVSP_PROTOCOL_VERSION_1, NVSP_PROTOCOL_VERSION_2,
 		NVSP_PROTOCOL_VERSION_4, NVSP_PROTOCOL_VERSION_5
 	};

Original file line number	Diff line number	Diff line change
`@@ -484,7 +484,7 @@ static int netvsc_connect_vsp(struct hv_device *device,`
`484`	`484`	`struct netvsc_device *net_device,`
`485`	`485`	`const struct netvsc_device_info *device_info)`
`486`	`486`	`{`
`487`		`- const u32 ver_list[] = {`
	`487`	`+ static const u32 ver_list[] = {`
`488`	`488`	`NVSP_PROTOCOL_VERSION_1, NVSP_PROTOCOL_VERSION_2,`
`489`	`489`	`NVSP_PROTOCOL_VERSION_4, NVSP_PROTOCOL_VERSION_5`
`490`	`490`	`};`