net/mlx4_core: destroy workqueue when driver fails to register

Wei Yang · davem330 · commit 1b85ee09aac2 · 2013-12-03T11:55:44.000-05:00
When driver registration fails, we need to clean up the resources allocated
before. mlx4_core missed destroying the workqueue allocated.

This patch destroys the workqueue when registration fails.

Signed-off-by: Wei Yang &lt;weiyang@linux.vnet.ibm.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -2635,6 +2635,8 @@ static int __init mlx4_init(void)
 		return -ENOMEM;
 
 	ret = pci_register_driver(&mlx4_driver);
+	if (ret < 0)
+		destroy_workqueue(mlx4_wq);
 	return ret < 0 ? ret : 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2635,6 +2635,8 @@ static int __init mlx4_init(void)`
`2635`	`2635`	`return -ENOMEM;`
`2636`	`2636`
`2637`	`2637`	`ret = pci_register_driver(&mlx4_driver);`
	`2638`	`+ if (ret < 0)`
	`2639`	`+ destroy_workqueue(mlx4_wq);`
`2638`	`2640`	`return ret < 0 ? ret : 0;`
`2639`	`2641`	`}`
`2640`	`2642`