net: dsa: mv88e6xxx: fix uninitialized error return

Colin Ian King · davem330 · commit 1d9619d5337d · 2016-04-28T16:29:20.000-04:00
The error return err is not initialized and there is a possibility
that err is not assigned causing mv88e6xxx_port_bridge_join to
return a garbage error return status. Fix this by initializing err
to 0.

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Reviewed-by: Vivien Didelot &lt;vivien.didelot@savoirfairelinux.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
@@ -2181,7 +2181,7 @@ int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port,
 			       struct net_device *bridge)
 {
 	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
-	int i, err;
+	int i, err = 0;
 
 	mutex_lock(&ps->smi_mutex);
 

Original file line number	Diff line number	Diff line change
`@@ -2181,7 +2181,7 @@ int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port,`
`2181`	`2181`	`struct net_device *bridge)`
`2182`	`2182`	`{`
`2183`	`2183`	`struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);`
`2184`		`- int i, err;`
	`2184`	`+ int i, err = 0;`
`2185`	`2185`
`2186`	`2186`	`mutex_lock(&ps->smi_mutex);`
`2187`	`2187`