platform/x86: dell-smbios: make a function and a pointer static

Colin Ian King · dvhart · commit 1e169ca3c4e3 · 2018-06-26T15:12:20.000-07:00
The function dell_smbios_smm_call and pointer platform_device are
local to the source and do not need to be in global scope, so make
them static.

Cleans up sparse warnings:
warning: symbol 'platform_device' was not declared. Should it be static?
warning: symbol 'dell_smbios_smm_call' was not declared. Should it be
static?

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Darren Hart (VMware) &lt;dvhart@infradead.org&gt;
diff --git a/drivers/platform/x86/dell-smbios-smm.c b/drivers/platform/x86/dell-smbios-smm.c
@@ -24,7 +24,7 @@
 static int da_command_address;
 static int da_command_code;
 static struct calling_interface_buffer *buffer;
-struct platform_device *platform_device;
+static struct platform_device *platform_device;
 static DEFINE_MUTEX(smm_mutex);
 
 static const struct dmi_system_id dell_device_table[] __initconst = {
@@ -82,7 +82,7 @@ static void find_cmd_address(const struct dmi_header *dm, void *dummy)
 	}
 }
 
-int dell_smbios_smm_call(struct calling_interface_buffer *input)
+static int dell_smbios_smm_call(struct calling_interface_buffer *input)
 {
 	struct smi_cmd command;
 	size_t size;

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`	`static int da_command_address;`
`25`	`25`	`static int da_command_code;`
`26`	`26`	`static struct calling_interface_buffer *buffer;`
`27`		`-struct platform_device *platform_device;`
	`27`	`+static struct platform_device *platform_device;`
`28`	`28`	`static DEFINE_MUTEX(smm_mutex);`
`29`	`29`
`30`	`30`	`static const struct dmi_system_id dell_device_table[] __initconst = {`
`@@ -82,7 +82,7 @@ static void find_cmd_address(const struct dmi_header dm, void dummy)`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`
`85`		`-int dell_smbios_smm_call(struct calling_interface_buffer *input)`
	`85`	`+static int dell_smbios_smm_call(struct calling_interface_buffer *input)`
`86`	`86`	`{`
`87`	`87`	`struct smi_cmd command;`
`88`	`88`	`size_t size;`