drm/i915/uc: Add message with firmware url

mwajdecz · jlahtine-intel · commit 1e913d27cef4 · 2017-10-16T18:53:28.000+03:00
In case of firmware fetch failure we should help user find latest firmware. URL macro duplication from csr.c will be fixed in upcoming patch. Suggested-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171016144724.17244-11-michal.wajdeczko@intel.com
diff --git a/drivers/gpu/drm/i915/intel_uc_fw.c b/drivers/gpu/drm/i915/intel_uc_fw.c
@@ -188,6 +188,8 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
 
 	DRM_WARN("%s: Failed to fetch firmware %s (error %d)\n",
 		 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);
+	DRM_INFO("%s: Firmware can be downloaded from %s\n",
+		 intel_uc_fw_type_repr(uc_fw->type), INTEL_UC_FIRMWARE_URL);
 
 	release_firmware(fw);		/* OK even if fw is NULL */
 }
diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h b/drivers/gpu/drm/i915/intel_uc_fw.h
@@ -27,6 +27,8 @@
 
 struct drm_i915_private;
 
+#define INTEL_UC_FIRMWARE_URL "https://01.org/linuxgraphics/downloads/firmware"
+
 enum intel_uc_fw_status {
 	INTEL_UC_FIRMWARE_FAIL = -1,
 	INTEL_UC_FIRMWARE_NONE = 0,

Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,8 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,`
`188`	`188`
`189`	`189`	`DRM_WARN("%s: Failed to fetch firmware %s (error %d)\n",`
`190`	`190`	`intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);`
	`191`	`+ DRM_INFO("%s: Firmware can be downloaded from %s\n",`
	`192`	`+ intel_uc_fw_type_repr(uc_fw->type), INTEL_UC_FIRMWARE_URL);`
`191`	`193`
`192`	`194`	`release_firmware(fw); /* OK even if fw is NULL */`
`193`	`195`	`}`