Skip to content

Commit 2072fe5

Browse files
Javier Martinez Canillasdaeinki
authored andcommitted
drm/exynos: Use VIDEO_SAMSUNG_S5P_G2D=n as G2D Kconfig dependency
Commit 254d4d1 ("drm/exynos: Add dependency for G2D in Kconfig") made the DRM_EXYNOS_G2D symbol to only be selectable if the s5p-g2d V4L2 driver is not enabled, since both use the same HW IP block. But added the dependency as depends on !VIDEO_SAMSUNG_S5P_G2D which isn't correct since Kconfig expressions are not boolean but tristate. So it will only evaluate to 'n' if VIDEO_SAMSUNG_S5P_G2D=y but it will evaluate to m if VIDEO_SAMSUNG_S5P_G2D=m. This means that both the V4L2 and DRM drivers can be enabled if the former is enabled as a module, which is not what we want. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Inki Dae <inki.dae@samsung.com>
1 parent 36ffc2b commit 2072fe5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/exynos/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ comment "Sub-drivers"
9494

9595
config DRM_EXYNOS_G2D
9696
bool "G2D"
97-
depends on !VIDEO_SAMSUNG_S5P_G2D
97+
depends on VIDEO_SAMSUNG_S5P_G2D=n
9898
select FRAME_VECTOR
9999
help
100100
Choose this option if you want to use Exynos G2D for DRM.

0 commit comments

Comments
 (0)