Skip to content

Commit 214f45c

Browse files
Eric Dumazetdavem330
authored andcommitted
net: provide default_advmss() methods to blackhole dst_ops
Commit 0dbaee3 (net: Abstract default ADVMSS behind an accessor.) introduced a possible crash in tcp_connect_init(), when dst->default_advmss() is called from dst_metric_advmss() Reported-by: George Spelvin <linux@horizon.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ed199fa commit 214f45c

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

net/ipv4/route.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2722,6 +2722,7 @@ static struct dst_ops ipv4_dst_blackhole_ops = {
27222722
.destroy = ipv4_dst_destroy,
27232723
.check = ipv4_blackhole_dst_check,
27242724
.default_mtu = ipv4_blackhole_default_mtu,
2725+
.default_advmss = ipv4_default_advmss,
27252726
.update_pmtu = ipv4_rt_blackhole_update_pmtu,
27262727
};
27272728

net/ipv6/route.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ static struct dst_ops ip6_dst_blackhole_ops = {
128128
.destroy = ip6_dst_destroy,
129129
.check = ip6_dst_check,
130130
.default_mtu = ip6_blackhole_default_mtu,
131+
.default_advmss = ip6_default_advmss,
131132
.update_pmtu = ip6_rt_blackhole_update_pmtu,
132133
};
133134

0 commit comments

Comments
 (0)