Skip to content

Commit 21bc7af

Browse files
yogeshpowarlinvjw
authored andcommitted
mwifiex: correct event header length
While decoding received event packet from firmware, 4 bytes of interface header are already removed unconditionally. So for handling event only 4 more bytes needs to be pulled. This is achieved by changing event header length to 4. Almost all the events, except BA stream related and AMSDU aggregation control events, do not have the payload in their event skb. Such events handling depends only on the event ID. This event ID is the first four bytes of the event skb, which is copied to a separate variable before pulling the skb header. Hence event handling worked only for those events that didn't have payload in event skb. This patch fixes the broken event path of the events with payload in their event skb without harming existing working event path for the events without payload. Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com> Signed-off-by: Kiran Divekar <dkiran@marvell.com> Signed-off-by: Bing Zhao <bzhao@marvell.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
1 parent daf8cf6 commit 21bc7af

File tree

1 file changed

+2
-2
lines changed
  • drivers/net/wireless/mwifiex

1 file changed

+2
-2
lines changed

drivers/net/wireless/mwifiex/sdio.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,8 @@
167167
/* Rx unit register */
168168
#define CARD_RX_UNIT_REG 0x63
169169

170-
/* Event header Len*/
171-
#define MWIFIEX_EVENT_HEADER_LEN 8
170+
/* Event header len w/o 4 bytes of interface header */
171+
#define MWIFIEX_EVENT_HEADER_LEN 4
172172

173173
/* Max retry number of CMD53 write */
174174
#define MAX_WRITE_IOMEM_RETRY 2

0 commit comments

Comments
 (0)