sctp: remove sctp_transport_pmtu_check

marceloleitner · davem330 · commit 22d7be267eaa · 2018-04-27T14:35:23.000-04:00
We are now keeping the MTU information synced between asoc, transport
and dst, which makes the check at sctp_packet_config() not needed
anymore. As it was the sole caller to this function, lets remove it.

Signed-off-by: Marcelo Ricardo Leitner &lt;marcelo.leitner@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h
@@ -606,16 +606,4 @@ static inline __u32 sctp_dst_mtu(const struct dst_entry *dst)
 				 SCTP_DEFAULT_MINSEGMENT));
 }
 
-static inline bool sctp_transport_pmtu_check(struct sctp_transport *t)
-{
-	__u32 pmtu = sctp_dst_mtu(t->dst);
-
-	if (t->pathmtu == pmtu)
-		return true;
-
-	t->pathmtu = pmtu;
-
-	return false;
-}
-
 #endif /* __net_sctp_h__ */
diff --git a/net/sctp/output.c b/net/sctp/output.c
@@ -118,9 +118,6 @@ void sctp_packet_config(struct sctp_packet *packet, __u32 vtag,
 		sctp_transport_route(tp, NULL, sp);
 		if (asoc->param_flags & SPP_PMTUD_ENABLE)
 			sctp_assoc_sync_pmtu(asoc);
-	} else if (!sctp_transport_pmtu_check(tp)) {
-		if (asoc->param_flags & SPP_PMTUD_ENABLE)
-			sctp_assoc_sync_pmtu(asoc);
 	}
 
 	/* If there a is a prepend chunk stick it on the list before

Original file line number	Diff line number	Diff line change
`@@ -118,9 +118,6 @@ void sctp_packet_config(struct sctp_packet *packet, __u32 vtag,`
`118`	`118`	`sctp_transport_route(tp, NULL, sp);`
`119`	`119`	`if (asoc->param_flags & SPP_PMTUD_ENABLE)`
`120`	`120`	`sctp_assoc_sync_pmtu(asoc);`
`121`		`- } else if (!sctp_transport_pmtu_check(tp)) {`
`122`		`- if (asoc->param_flags & SPP_PMTUD_ENABLE)`
`123`		`- sctp_assoc_sync_pmtu(asoc);`
`124`	`121`	`}`
`125`	`122`
`126`	`123`	`/* If there a is a prepend chunk stick it on the list before`