xen: xenbus: set error code on failure

SinkFinder · jgross1 · commit 2466d4b9d0c2 · 2016-12-08T07:53:57.000+01:00
Variable err is initialized with 0. As a result, the return value may
be 0 even if get_zeroed_page() fails to allocate memory. This patch fixes
the bug, initializing err with "-ENOMEM".

Signed-off-by: Pan Bian &lt;bianpan2016@163.com&gt;
Reviewed-by: Juergen Gross &lt;jgross@suse.com&gt;
Signed-off-by: Juergen Gross &lt;jgross@suse.com&gt;
diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
@@ -702,7 +702,7 @@ device_initcall(xenbus_probe_initcall);
  */
 static int __init xenstored_local_init(void)
 {
-	int err = 0;
+	int err = -ENOMEM;
 	unsigned long page = 0;
 	struct evtchn_alloc_unbound alloc_unbound;
 

Original file line number	Diff line number	Diff line change
`@@ -702,7 +702,7 @@ device_initcall(xenbus_probe_initcall);`
`702`	`702`	`*/`
`703`	`703`	`static int __init xenstored_local_init(void)`
`704`	`704`	`{`
`705`		`- int err = 0;`
	`705`	`+ int err = -ENOMEM;`
`706`	`706`	`unsigned long page = 0;`
`707`	`707`	`struct evtchn_alloc_unbound alloc_unbound;`
`708`	`708`