Skip to content

Commit 28b39bc

Browse files
jasowangdavem330
authored andcommitted
virtio-net: pack headroom into ctx for mergeable buffers
Pack headroom into ctx - this way when we get a buffer we can figure out the actual headroom that was allocated for the buffer. Will be helpful to optimize switching between XDP and non-XDP modes which have different headroom requirements. Signed-off-by: Jason Wang <jasowang@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 87646a3 commit 28b39bc

File tree

1 file changed

+24
-5
lines changed

1 file changed

+24
-5
lines changed

drivers/net/virtio_net.c

Lines changed: 24 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,23 @@ static void skb_xmit_done(struct virtqueue *vq)
270270
netif_wake_subqueue(vi->dev, vq2txq(vq));
271271
}
272272

273+
#define MRG_CTX_HEADER_SHIFT 22
274+
static void *mergeable_len_to_ctx(unsigned int truesize,
275+
unsigned int headroom)
276+
{
277+
return (void *)(unsigned long)((headroom << MRG_CTX_HEADER_SHIFT) | truesize);
278+
}
279+
280+
static unsigned int mergeable_ctx_to_headroom(void *mrg_ctx)
281+
{
282+
return (unsigned long)mrg_ctx >> MRG_CTX_HEADER_SHIFT;
283+
}
284+
285+
static unsigned int mergeable_ctx_to_truesize(void *mrg_ctx)
286+
{
287+
return (unsigned long)mrg_ctx & ((1 << MRG_CTX_HEADER_SHIFT) - 1);
288+
}
289+
273290
/* Called from bottom half context */
274291
static struct sk_buff *page_to_skb(struct virtnet_info *vi,
275292
struct receive_queue *rq,
@@ -639,13 +656,14 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
639656
}
640657
rcu_read_unlock();
641658

642-
if (unlikely(len > (unsigned long)ctx)) {
659+
truesize = mergeable_ctx_to_truesize(ctx);
660+
if (unlikely(len > truesize)) {
643661
pr_debug("%s: rx error: len %u exceeds truesize %lu\n",
644662
dev->name, len, (unsigned long)ctx);
645663
dev->stats.rx_length_errors++;
646664
goto err_skb;
647665
}
648-
truesize = (unsigned long)ctx;
666+
649667
head_skb = page_to_skb(vi, rq, page, offset, len, truesize);
650668
curr_skb = head_skb;
651669

@@ -665,13 +683,14 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
665683
}
666684

667685
page = virt_to_head_page(buf);
668-
if (unlikely(len > (unsigned long)ctx)) {
686+
687+
truesize = mergeable_ctx_to_truesize(ctx);
688+
if (unlikely(len > truesize)) {
669689
pr_debug("%s: rx error: len %u exceeds truesize %lu\n",
670690
dev->name, len, (unsigned long)ctx);
671691
dev->stats.rx_length_errors++;
672692
goto err_skb;
673693
}
674-
truesize = (unsigned long)ctx;
675694

676695
num_skb_frags = skb_shinfo(curr_skb)->nr_frags;
677696
if (unlikely(num_skb_frags == MAX_SKB_FRAGS)) {
@@ -889,7 +908,7 @@ static int add_recvbuf_mergeable(struct virtnet_info *vi,
889908

890909
buf = (char *)page_address(alloc_frag->page) + alloc_frag->offset;
891910
buf += headroom; /* advance address leaving hole at front of pkt */
892-
ctx = (void *)(unsigned long)len;
911+
ctx = mergeable_len_to_ctx(len, headroom);
893912
get_page(alloc_frag->page);
894913
alloc_frag->offset += len + headroom;
895914
hole = alloc_frag->size - alloc_frag->offset;

0 commit comments

Comments
 (0)