x86, intel-mid: Return proper error code from get_gpio_by_name()

David Cohen · H. Peter Anvin · commit 28c6a39b3367 · 2014-01-16T15:07:36.000-08:00
This patch cleans up get_gpio_by_name() to return an error code instead of hardcoded -1. Signed-off-by: David Cohen <david.a.cohen@linux.intel.com> Link: http://lkml.kernel.org/r/1389913624-9149-4-git-send-email-david.a.cohen@linux.intel.com Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
diff --git a/arch/x86/platform/intel-mid/sfi.c b/arch/x86/platform/intel-mid/sfi.c
@@ -224,7 +224,7 @@ int get_gpio_by_name(const char *name)
 		if (!strncmp(name, pentry->pin_name, SFI_NAME_LEN))
 			return pentry->pin_no;
 	}
-	return -1;
+	return -EINVAL;
 }
 
 void __init intel_scu_device_register(struct platform_device *pdev)

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ int get_gpio_by_name(const char *name)`
`224`	`224`	`if (!strncmp(name, pentry->pin_name, SFI_NAME_LEN))`
`225`	`225`	`return pentry->pin_no;`
`226`	`226`	`}`
`227`		`- return -1;`
	`227`	`+ return -EINVAL;`
`228`	`228`	`}`
`229`	`229`
`230`	`230`	`void __init intel_scu_device_register(struct platform_device *pdev)`