Skip to content

Commit 28cf71c

Browse files
Lyudedanvet
authored andcommitted
drm/i915/vlv: Make intel_crt_reset() per-encoder
This lets call intel_crt_reset() in contexts where IRQs are disabled and as such, can't hold the locks required to work with the connectors. Cc: stable@vger.kernel.org Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Lyude <cpaul@redhat.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
1 parent fb7404e commit 28cf71c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/gpu/drm/i915/intel_crt.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -717,11 +717,11 @@ static int intel_crt_set_property(struct drm_connector *connector,
717717
return 0;
718718
}
719719

720-
static void intel_crt_reset(struct drm_connector *connector)
720+
static void intel_crt_reset(struct drm_encoder *encoder)
721721
{
722-
struct drm_device *dev = connector->dev;
722+
struct drm_device *dev = encoder->dev;
723723
struct drm_i915_private *dev_priv = to_i915(dev);
724-
struct intel_crt *crt = intel_attached_crt(connector);
724+
struct intel_crt *crt = intel_encoder_to_crt(to_intel_encoder(encoder));
725725

726726
if (INTEL_INFO(dev)->gen >= 5) {
727727
u32 adpa;
@@ -743,7 +743,6 @@ static void intel_crt_reset(struct drm_connector *connector)
743743
*/
744744

745745
static const struct drm_connector_funcs intel_crt_connector_funcs = {
746-
.reset = intel_crt_reset,
747746
.dpms = drm_atomic_helper_connector_dpms,
748747
.detect = intel_crt_detect,
749748
.fill_modes = drm_helper_probe_single_connector_modes,
@@ -762,6 +761,7 @@ static const struct drm_connector_helper_funcs intel_crt_connector_helper_funcs
762761
};
763762

764763
static const struct drm_encoder_funcs intel_crt_enc_funcs = {
764+
.reset = intel_crt_reset,
765765
.destroy = intel_encoder_destroy,
766766
};
767767

@@ -904,5 +904,5 @@ void intel_crt_init(struct drm_device *dev)
904904
dev_priv->fdi_rx_config = I915_READ(FDI_RX_CTL(PIPE_A)) & fdi_config;
905905
}
906906

907-
intel_crt_reset(connector);
907+
intel_crt_reset(&crt->base.base);
908908
}

0 commit comments

Comments
 (0)