Skip to content

Commit 28d304e

Browse files
YueHaibingdavem330
authored andcommitted
net: sgi: fix return type of ndo_start_xmit function
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent f3bf939 commit 28d304e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

drivers/net/ethernet/sgi/ioc3-eth.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ struct ioc3_private {
9999

100100
static int ioc3_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);
101101
static void ioc3_set_multicast_list(struct net_device *dev);
102-
static int ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev);
102+
static netdev_tx_t ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev);
103103
static void ioc3_timeout(struct net_device *dev);
104104
static inline unsigned int ioc3_hash(const unsigned char *addr);
105105
static inline void ioc3_stop(struct ioc3_private *ip);
@@ -1390,7 +1390,7 @@ static struct pci_driver ioc3_driver = {
13901390
.remove = ioc3_remove_one,
13911391
};
13921392

1393-
static int ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev)
1393+
static netdev_tx_t ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev)
13941394
{
13951395
unsigned long data;
13961396
struct ioc3_private *ip = netdev_priv(dev);

drivers/net/ethernet/sgi/meth.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ static void meth_add_to_tx_ring(struct meth_private *priv, struct sk_buff *skb)
697697
/*
698698
* Transmit a packet (called by the kernel)
699699
*/
700-
static int meth_tx(struct sk_buff *skb, struct net_device *dev)
700+
static netdev_tx_t meth_tx(struct sk_buff *skb, struct net_device *dev)
701701
{
702702
struct meth_private *priv = netdev_priv(dev);
703703
unsigned long flags;

0 commit comments

Comments
 (0)