Skip to content

Commit 28e2c4b

Browse files
thejhgregkh
authored andcommitted
mm/vmstat.c: fix outdated vmstat_text
7a9cdeb ("mm: get rid of vmacache_flush_all() entirely") removed the VMACACHE_FULL_FLUSHES statistics, but didn't remove the corresponding entry in vmstat_text. This causes an out-of-bounds access in vmstat_show(). Luckily this only affects kernels with CONFIG_DEBUG_VM_VMACACHE=y, which is probably very rare. Link: http://lkml.kernel.org/r/20181001143138.95119-1-jannh@google.com Fixes: 7a9cdeb ("mm: get rid of vmacache_flush_all() entirely") Signed-off-by: Jann Horn <jannh@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: Roman Gushchin <guro@fb.com> Cc: Davidlohr Bueso <dave@stgolabs.net> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Christoph Lameter <clameter@sgi.com> Cc: Kemi Wang <kemi.wang@intel.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Ingo Molnar <mingo@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f8a00ce commit 28e2c4b

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

mm/vmstat.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1283,7 +1283,6 @@ const char * const vmstat_text[] = {
12831283
#ifdef CONFIG_DEBUG_VM_VMACACHE
12841284
"vmacache_find_calls",
12851285
"vmacache_find_hits",
1286-
"vmacache_full_flushes",
12871286
#endif
12881287
#ifdef CONFIG_SWAP
12891288
"swap_ra",

0 commit comments

Comments
 (0)