Skip to content

Commit 29214e8

Browse files
RavirajSitaramvsyrjala
authored andcommitted
drm/i915: correct the pitch check for NV12 framebuffer
framebuffer for NV12 requires the pitch to the multiplier of 4, instead of the width. This patch corrects it. For instance, a 480p video, whose width and pitch are 854 and 896 respectively, is excluded for NV12 plane so far. Changes since v1: - Removed check for NV12 buffer dimensions since additional checks are done for viewport size in intel_sprite.c Signed-off-by: Dongseong Hwang <dongseong.hwang@intel.com> Signed-off-by: P Raviraj Sitaram <raviraj.p.sitaram@intel.com> Cc: Chandra Konduru <chandra.konduru@intel.com> Cc: Vidya Srinivas <vidya.srinivas@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/1545208152-22658-1-git-send-email-raviraj.p.sitaram@intel.com
1 parent 790cc99 commit 29214e8

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/gpu/drm/i915/intel_display.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14710,14 +14710,6 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
1471014710

1471114711
drm_helper_mode_fill_fb_struct(&dev_priv->drm, fb, mode_cmd);
1471214712

14713-
if (fb->format->format == DRM_FORMAT_NV12 &&
14714-
(fb->width < SKL_MIN_YUV_420_SRC_W ||
14715-
fb->height < SKL_MIN_YUV_420_SRC_H ||
14716-
(fb->width % 4) != 0 || (fb->height % 4) != 0)) {
14717-
DRM_DEBUG_KMS("src dimensions not correct for NV12\n");
14718-
goto err;
14719-
}
14720-
1472114713
for (i = 0; i < fb->format->num_planes; i++) {
1472214714
u32 stride_alignment;
1472314715

0 commit comments

Comments
 (0)