PCI/MSI: Fix leak of msi_attrs

gregkh · bjorn-helgaas · commit 29237756477d · 2014-02-13T10:47:35.000-07:00
Coverity reported that I forgot to clean up some allocated memory on the error path in populate_msi_sysfs(), so this patch fixes that. Thanks to Dave Jones for pointing out where the error was, I obviously can't read code this morning... Found by Coverity (CID 1163317). Fixes: 1c51b50 ("PCI/MSI: Export MSI mode using attributes, not kobjects") Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Cc: Dave Jones <davej@redhat.com>
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
@@ -595,6 +595,7 @@ static int populate_msi_sysfs(struct pci_dev *pdev)
 		++count;
 		msi_attr = msi_attrs[count];
 	}
+	kfree(msi_attrs);
 	return ret;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -595,6 +595,7 @@ static int populate_msi_sysfs(struct pci_dev *pdev)`
`595`	`595`	`++count;`
`596`	`596`	`msi_attr = msi_attrs[count];`
`597`	`597`	`}`
	`598`	`+ kfree(msi_attrs);`
`598`	`599`	`return ret;`
`599`	`600`	`}`
`600`	`601`