pktgen: Fix memory leak in pktgen_if_write

GustavoARSilva · davem330 · commit 29d1df72ce2a · 2018-03-14T10:02:15.000-04:00
_buf_ is an array and the one that must be freed is _tp_ instead. Fixes: a870a02 ("pktgen: use dynamic allocation for debug print buffer") Reported-by: Wang Jian <jianjian.wang1@gmail.com> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
@@ -913,7 +913,7 @@ static ssize_t pktgen_if_write(struct file *file,
 			return PTR_ERR(tp);
 
 		pr_debug("%s,%zu  buffer -:%s:-\n", name, count, tp);
-		kfree(buf);
+		kfree(tp);
 	}
 
 	if (!strcmp(name, "min_pkt_size")) {

Original file line number	Diff line number	Diff line change
`@@ -913,7 +913,7 @@ static ssize_t pktgen_if_write(struct file *file,`
`913`	`913`	`return PTR_ERR(tp);`
`914`	`914`
`915`	`915`	`pr_debug("%s,%zu buffer -:%s:-\n", name, count, tp);`
`916`		`- kfree(buf);`
	`916`	`+ kfree(tp);`
`917`	`917`	`}`
`918`	`918`
`919`	`919`	`if (!strcmp(name, "min_pkt_size")) {`