Skip to content

Commit 2b1f18a

Browse files
Wei Yongjundavem330
authored andcommitted
qlcnic: add missing destroy_workqueue() on error path in qlcnic_probe()
Add the missing destroy_workqueue() before return from qlcnic_probe() in the error handling case. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent bdfd630 commit 2b1f18a

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2257,7 +2257,7 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
22572257

22582258
err = qlcnic_alloc_adapter_resources(adapter);
22592259
if (err)
2260-
goto err_out_free_netdev;
2260+
goto err_out_free_wq;
22612261

22622262
adapter->dev_rst_time = jiffies;
22632263
adapter->ahw->revision_id = pdev->revision;
@@ -2396,6 +2396,9 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
23962396
err_out_free_hw:
23972397
qlcnic_free_adapter_resources(adapter);
23982398

2399+
err_out_free_wq:
2400+
destroy_workqueue(adapter->qlcnic_wq);
2401+
23992402
err_out_free_netdev:
24002403
free_netdev(netdev);
24012404

0 commit comments

Comments
 (0)