Skip to content

Commit 2b313dd

Browse files
sumanannajoergroedel
authored andcommitted
iommu/omap: Remove ver debugfs entry
The debugfs entry 'ver' to read the OMAP IOMMU version is not much useful for developers, so it has been removed. The same can be deduced from the register dump, provided by the debugfs entry 'regs', REVISION register. This also allows us to remove the omap_iommu_arch_revision() which is currently returning a fixed value. Signed-off-by: Suman Anna <s-anna@ti.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 533b40c commit 2b313dd

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

drivers/iommu/omap-iommu-debug.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,6 @@ static DEFINE_MUTEX(iommu_debug_lock);
3030

3131
static struct dentry *iommu_debug_root;
3232

33-
static ssize_t debug_read_ver(struct file *file, char __user *userbuf,
34-
size_t count, loff_t *ppos)
35-
{
36-
u32 ver = omap_iommu_arch_version();
37-
char buf[MAXCOLUMN], *p = buf;
38-
39-
p += sprintf(p, "H/W version: %d.%d\n", (ver >> 4) & 0xf , ver & 0xf);
40-
41-
return simple_read_from_buffer(userbuf, count, ppos, buf, p - buf);
42-
}
43-
4433
static ssize_t debug_read_regs(struct file *file, char __user *userbuf,
4534
size_t count, loff_t *ppos)
4635
{
@@ -228,7 +217,6 @@ static ssize_t debug_read_pagetable(struct file *file, char __user *userbuf,
228217
.llseek = generic_file_llseek, \
229218
};
230219

231-
DEBUG_FOPS_RO(ver);
232220
DEBUG_FOPS_RO(regs);
233221
DEBUG_FOPS_RO(tlb);
234222
DEBUG_FOPS(pagetable);
@@ -273,7 +261,6 @@ static int iommu_debug_register(struct device *dev, void *data)
273261
if (!d)
274262
goto nomem;
275263

276-
DEBUG_ADD_FILE_RO(ver);
277264
DEBUG_ADD_FILE_RO(regs);
278265
DEBUG_ADD_FILE_RO(tlb);
279266
DEBUG_ADD_FILE(pagetable);

0 commit comments

Comments
 (0)