drm/shmobile: Restrict plane loops to only operate on legacy planes

mattrope · robclark · commit 2b79dc13dc88 · 2014-04-01T20:11:27.000-04:00
Ensure that existing driver loops over all planes do not change behavior
when we begin adding new types of planes (primary and cursor) to the DRM
plane list in future patches.

Acked-by: Laurent Pinchart &lt;laurent.pinchart@ideasonboard.com&gt;
Signed-off-by: Matt Roper &lt;matthew.d.roper@intel.com&gt;
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
@@ -247,7 +247,7 @@ static void shmob_drm_crtc_start(struct shmob_drm_crtc *scrtc)
 	lcdc_write(sdev, LDDDSR, value);
 
 	/* Setup planes. */
-	list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
+	drm_for_each_legacy_plane(plane, &dev->mode_config.plane_list) {
 		if (plane->crtc == crtc)
 			shmob_drm_plane_setup(plane);
 	}

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ static void shmob_drm_crtc_start(struct shmob_drm_crtc *scrtc)`
`247`	`247`	`lcdc_write(sdev, LDDDSR, value);`
`248`	`248`
`249`	`249`	`/* Setup planes. */`
`250`		`- list_for_each_entry(plane, &dev->mode_config.plane_list, head) {`
	`250`	`+ drm_for_each_legacy_plane(plane, &dev->mode_config.plane_list) {`
`251`	`251`	`if (plane->crtc == crtc)`
`252`	`252`	`shmob_drm_plane_setup(plane);`
`253`	`253`	`}`