bfin_mac: fix error return code in bfin_mac_probe()

Wei Yongjun · davem330 · commit 2c006994520f · 2013-05-08T13:13:30.000-07:00
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun &lt;yongjun_wei@trendmicro.com.cn&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c
@@ -1700,7 +1700,8 @@ static int bfin_mac_probe(struct platform_device *pdev)
 	}
 
 	bfin_mac_hwtstamp_init(ndev);
-	if (bfin_phc_init(ndev, &pdev->dev)) {
+	rc = bfin_phc_init(ndev, &pdev->dev);
+	if (rc) {
 		dev_err(&pdev->dev, "Cannot register PHC device!\n");
 		goto out_err_phc;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1700,7 +1700,8 @@ static int bfin_mac_probe(struct platform_device *pdev)`
`1700`	`1700`	`}`
`1701`	`1701`
`1702`	`1702`	`bfin_mac_hwtstamp_init(ndev);`
`1703`		`- if (bfin_phc_init(ndev, &pdev->dev)) {`
	`1703`	`+ rc = bfin_phc_init(ndev, &pdev->dev);`
	`1704`	`+ if (rc) {`
`1704`	`1705`	`dev_err(&pdev->dev, "Cannot register PHC device!\n");`
`1705`	`1706`	`goto out_err_phc;`
`1706`	`1707`	`}`