Skip to content

Commit 2f6a026

Browse files
Ivan Veceradavem330
authored andcommitted
be2net: fix vfs enumeration
Current VFs enumeration algorithm used in be_find_vfs does not take domain number into the match. The match found in igb/ixgbe is more elegant and safe. This 2nd version uses pci_physfn instead of checking dev->physfn directly. Signed-off-by: Ivan Vecera <ivecera@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent f4b549a commit 2f6a026

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/net/ethernet/emulex/benet/be_main.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1075,7 +1075,7 @@ static int be_set_vf_tx_rate(struct net_device *netdev,
10751075
static int be_find_vfs(struct be_adapter *adapter, int vf_state)
10761076
{
10771077
struct pci_dev *dev, *pdev = adapter->pdev;
1078-
int vfs = 0, assigned_vfs = 0, pos, vf_fn;
1078+
int vfs = 0, assigned_vfs = 0, pos;
10791079
u16 offset, stride;
10801080

10811081
pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_SRIOV);
@@ -1086,9 +1086,7 @@ static int be_find_vfs(struct be_adapter *adapter, int vf_state)
10861086

10871087
dev = pci_get_device(pdev->vendor, PCI_ANY_ID, NULL);
10881088
while (dev) {
1089-
vf_fn = (pdev->devfn + offset + stride * vfs) & 0xFFFF;
1090-
if (dev->is_virtfn && dev->devfn == vf_fn &&
1091-
dev->bus->number == pdev->bus->number) {
1089+
if (dev->is_virtfn && pci_physfn(dev) == pdev) {
10921090
vfs++;
10931091
if (dev->dev_flags & PCI_DEV_FLAGS_ASSIGNED)
10941092
assigned_vfs++;

0 commit comments

Comments
 (0)