Skip to content

Commit 3063287

Browse files
author
Tyler Hicks
committed
eCryptfs: Remove ecryptfs_header_cache_2
Now that ecryptfs_lookup_interpose() is no longer using ecryptfs_header_cache_2 to read in metadata, the kmem_cache can be removed and the ecryptfs_header_cache_1 kmem_cache can be renamed to ecryptfs_header_cache. Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
1 parent 778aeb4 commit 3063287

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

fs/ecryptfs/crypto.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1234,8 +1234,7 @@ ecryptfs_write_header_metadata(char *virt,
12341234
(*written) = 6;
12351235
}
12361236

1237-
struct kmem_cache *ecryptfs_header_cache_1;
1238-
struct kmem_cache *ecryptfs_header_cache_2;
1237+
struct kmem_cache *ecryptfs_header_cache;
12391238

12401239
/**
12411240
* ecryptfs_write_headers_virt
@@ -1601,7 +1600,7 @@ int ecryptfs_read_metadata(struct dentry *ecryptfs_dentry)
16011600
ecryptfs_copy_mount_wide_flags_to_inode_flags(crypt_stat,
16021601
mount_crypt_stat);
16031602
/* Read the first page from the underlying file */
1604-
page_virt = kmem_cache_alloc(ecryptfs_header_cache_1, GFP_USER);
1603+
page_virt = kmem_cache_alloc(ecryptfs_header_cache, GFP_USER);
16051604
if (!page_virt) {
16061605
rc = -ENOMEM;
16071606
printk(KERN_ERR "%s: Unable to allocate page_virt\n",
@@ -1646,7 +1645,7 @@ int ecryptfs_read_metadata(struct dentry *ecryptfs_dentry)
16461645
out:
16471646
if (page_virt) {
16481647
memset(page_virt, 0, PAGE_CACHE_SIZE);
1649-
kmem_cache_free(ecryptfs_header_cache_1, page_virt);
1648+
kmem_cache_free(ecryptfs_header_cache, page_virt);
16501649
}
16511650
return rc;
16521651
}

fs/ecryptfs/ecryptfs_kernel.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -605,8 +605,7 @@ extern struct kmem_cache *ecryptfs_file_info_cache;
605605
extern struct kmem_cache *ecryptfs_dentry_info_cache;
606606
extern struct kmem_cache *ecryptfs_inode_info_cache;
607607
extern struct kmem_cache *ecryptfs_sb_info_cache;
608-
extern struct kmem_cache *ecryptfs_header_cache_1;
609-
extern struct kmem_cache *ecryptfs_header_cache_2;
608+
extern struct kmem_cache *ecryptfs_header_cache;
610609
extern struct kmem_cache *ecryptfs_xattr_cache;
611610
extern struct kmem_cache *ecryptfs_key_record_cache;
612611
extern struct kmem_cache *ecryptfs_key_sig_cache;

fs/ecryptfs/main.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -635,13 +635,8 @@ static struct ecryptfs_cache_info {
635635
.size = sizeof(struct ecryptfs_sb_info),
636636
},
637637
{
638-
.cache = &ecryptfs_header_cache_1,
639-
.name = "ecryptfs_headers_1",
640-
.size = PAGE_CACHE_SIZE,
641-
},
642-
{
643-
.cache = &ecryptfs_header_cache_2,
644-
.name = "ecryptfs_headers_2",
638+
.cache = &ecryptfs_header_cache,
639+
.name = "ecryptfs_headers",
645640
.size = PAGE_CACHE_SIZE,
646641
},
647642
{

0 commit comments

Comments
 (0)