Skip to content

Commit 321acc1

Browse files
akodanevdavem330
authored andcommitted
geneve: check MTU for a minimum in geneve_change_mtu()
geneve_change_mtu() will be used not only as ndo_change_mtu() callback, but also to verify a user specified MTU on a new link creation in the next patch. Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5edbea6 commit 321acc1

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/net/geneve.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -942,11 +942,10 @@ static netdev_tx_t geneve_xmit(struct sk_buff *skb, struct net_device *dev)
942942

943943
static int geneve_change_mtu(struct net_device *dev, int new_mtu)
944944
{
945-
/* Only possible if called internally, ndo_change_mtu path's new_mtu
946-
* is guaranteed to be between dev->min_mtu and dev->max_mtu.
947-
*/
948945
if (new_mtu > dev->max_mtu)
949946
new_mtu = dev->max_mtu;
947+
else if (new_mtu < dev->min_mtu)
948+
new_mtu = dev->min_mtu;
950949

951950
dev->mtu = new_mtu;
952951
return 0;

0 commit comments

Comments
 (0)