MIPS: Modify error handling

musicakc · ralfbaechle · commit 33799a6d1aeb · 2016-08-01T22:54:48.000+02:00
debugfs_create_file returns NULL on error so an IS_ERR test is incorrect here and a NULL check is required. The Coccinelle semantic patch used to make this change is as follows: @@ expression e; @@ e = debugfs_create_file(...); if( - IS_ERR(e) + !e ) { <+... return - PTR_ERR(e) + -ENOMEM ; ...+> } Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Cc: julia.lawall@lip6.fr Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/13834/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/arch/mips/mm/sc-debugfs.c b/arch/mips/mm/sc-debugfs.c
@@ -73,8 +73,8 @@ static int __init sc_debugfs_init(void)
 
 	file = debugfs_create_file("prefetch", S_IRUGO | S_IWUSR, dir,
 				   NULL, &sc_prefetch_fops);
-	if (IS_ERR(file))
-		return PTR_ERR(file);
+	if (!file)
+		return -ENOMEM;
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,8 @@ static int __init sc_debugfs_init(void)`
`73`	`73`
`74`	`74`	`file = debugfs_create_file("prefetch", S_IRUGO \| S_IWUSR, dir,`
`75`	`75`	`NULL, &sc_prefetch_fops);`
`76`		`- if (IS_ERR(file))`
`77`		`- return PTR_ERR(file);`
	`76`	`+ if (!file)`
	`77`	`+ return -ENOMEM;`
`78`	`78`
`79`	`79`	`return 0;`
`80`	`80`	`}`