KVM: x86: work around leak of uninitialized stack contents (CVE-2019-7222)

bonzini · bonzini · commit 353c0956a618 · 2019-02-07T19:02:56.000+01:00
Bugzilla: 1671930

Emulation of certain instructions (VMXON, VMCLEAR, VMPTRLD, VMWRITE with
memory operand, INVEPT, INVVPID) can incorrectly inject a page fault
when passed an operand that points to an MMIO address.  The page fault
will use uninitialized kernel stack memory as the CR2 and error code.

The right behavior would be to abort the VM with a KVM_EXIT_INTERNAL_ERROR
exit to userspace; however, it is not an easy fix, so for now just
ensure that the error code and CR2 are zero.

Embargoed until Feb 7th 2019.

Reported-by: Felix Wilhelm &lt;fwilhelm@google.com&gt;
Cc: stable@kernel.org
Signed-off-by: Paolo Bonzini &lt;pbonzini@redhat.com&gt;
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
@@ -5116,6 +5116,13 @@ int kvm_read_guest_virt(struct kvm_vcpu *vcpu,
 {
 	u32 access = (kvm_x86_ops->get_cpl(vcpu) == 3) ? PFERR_USER_MASK : 0;
 
+	/*
+	 * FIXME: this should call handle_emulation_failure if X86EMUL_IO_NEEDED
+	 * is returned, but our callers are not ready for that and they blindly
+	 * call kvm_inject_page_fault.  Ensure that they at least do not leak
+	 * uninitialized kernel stack memory into cr2 and error code.
+	 */
+	memset(exception, 0, sizeof(*exception));
 	return kvm_read_guest_virt_helper(addr, val, bytes, vcpu, access,
 					  exception);
 }

Original file line number	Diff line number	Diff line change
`@@ -5116,6 +5116,13 @@ int kvm_read_guest_virt(struct kvm_vcpu *vcpu,`
`5116`	`5116`	`{`
`5117`	`5117`	`u32 access = (kvm_x86_ops->get_cpl(vcpu) == 3) ? PFERR_USER_MASK : 0;`
`5118`	`5118`
	`5119`	`+ /*`
	`5120`	`+ * FIXME: this should call handle_emulation_failure if X86EMUL_IO_NEEDED`
	`5121`	`+ * is returned, but our callers are not ready for that and they blindly`
	`5122`	`+ * call kvm_inject_page_fault. Ensure that they at least do not leak`
	`5123`	`+ * uninitialized kernel stack memory into cr2 and error code.`
	`5124`	`+ */`
	`5125`	`+ memset(exception, 0, sizeof(*exception));`
`5119`	`5126`	`return kvm_read_guest_virt_helper(addr, val, bytes, vcpu, access,`
`5120`	`5127`	`exception);`
`5121`	`5128`	`}`