scsi: lpfc: Use dma_zalloc_coherent

Sabyasachi Gupta · martinkpetersen · commit 359d0ac1e806 · 2018-11-21T22:31:22.000-05:00
Replaced dma_alloc_coherent + memset with dma_zalloc_coherent.

Signed-off-by: Sabyasachi Gupta &lt;sabyasachi.linux@gmail.com&gt;
Acked-by: James Smart &lt;james.smart@broadcom.com&gt;
Signed-off-by: Martin K. Petersen &lt;martin.petersen@oracle.com&gt;
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
@@ -6229,7 +6229,7 @@ lpfc_sli4_ras_dma_alloc(struct lpfc_hba *phba,
 			goto free_mem;
 		}
 
-		dmabuf->virt = dma_alloc_coherent(&phba->pcidev->dev,
+		dmabuf->virt = dma_zalloc_coherent(&phba->pcidev->dev,
 						  LPFC_RAS_MAX_ENTRY_SIZE,
 						  &dmabuf->phys,
 						  GFP_KERNEL);
@@ -6240,7 +6240,6 @@ lpfc_sli4_ras_dma_alloc(struct lpfc_hba *phba,
 					"6187 DMA Alloc Failed FW logging");
 			goto free_mem;
 		}
-		memset(dmabuf->virt, 0, LPFC_RAS_MAX_ENTRY_SIZE);
 		dmabuf->buffer_tag = i;
 		list_add_tail(&dmabuf->list, &ras_fwlog->fwlog_buff_list);
 	}

Original file line number	Diff line number	Diff line change
`@@ -6229,7 +6229,7 @@ lpfc_sli4_ras_dma_alloc(struct lpfc_hba *phba,`
`6229`	`6229`	`goto free_mem;`
`6230`	`6230`	`}`
`6231`	`6231`
`6232`		`- dmabuf->virt = dma_alloc_coherent(&phba->pcidev->dev,`
	`6232`	`+ dmabuf->virt = dma_zalloc_coherent(&phba->pcidev->dev,`
`6233`	`6233`	`LPFC_RAS_MAX_ENTRY_SIZE,`
`6234`	`6234`	`&dmabuf->phys,`
`6235`	`6235`	`GFP_KERNEL);`
`@@ -6240,7 +6240,6 @@ lpfc_sli4_ras_dma_alloc(struct lpfc_hba *phba,`
`6240`	`6240`	`"6187 DMA Alloc Failed FW logging");`
`6241`	`6241`	`goto free_mem;`
`6242`	`6242`	`}`
`6243`		`- memset(dmabuf->virt, 0, LPFC_RAS_MAX_ENTRY_SIZE);`
`6244`	`6243`	`dmabuf->buffer_tag = i;`
`6245`	`6244`	`list_add_tail(&dmabuf->list, &ras_fwlog->fwlog_buff_list);`
`6246`	`6245`	`}`