ACPI / video: update condition to check if device is in _DOD list

Aaron Lu · rafaeljw · commit 35d0565b9554 · 2014-12-01T02:09:18.000+01:00
Commit 0b8db27 ("ACPI / video: check _DOD list when creating backlight devices") checks if the video device is in the bind devices list to decide if we should create backlight device for it, that causes problem for one Dell Latitude E6410, where none of the video output devices are properly bound due to the way how we did the comparing between its _ADR and the _DOD's values. Solve this problem by comparing the lower 12 bits of both the device's _ADR and the _DOD's values instead of relying on bind result. Fixes: 0b8db27 ("ACPI / video: check _DOD list when creating backlight devices") Reported-and-tested-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Aaron Lu <aaron.lu@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
@@ -1164,7 +1164,8 @@ static bool acpi_video_device_in_dod(struct acpi_video_device *device)
 		return true;
 
 	for (i = 0; i < video->attached_count; i++) {
-		if (video->attached_array[i].bind_info == device)
+		if ((video->attached_array[i].value.int_val & 0xfff) ==
+		    (device->device_id & 0xfff))
 			return true;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1164,7 +1164,8 @@ static bool acpi_video_device_in_dod(struct acpi_video_device *device)`
`1164`	`1164`	`return true;`
`1165`	`1165`
`1166`	`1166`	`for (i = 0; i < video->attached_count; i++) {`
`1167`		`- if (video->attached_array[i].bind_info == device)`
	`1167`	`+ if ((video->attached_array[i].value.int_val & 0xfff) ==`
	`1168`	`+ (device->device_id & 0xfff))`
`1168`	`1169`	`return true;`
`1169`	`1170`	`}`
`1170`	`1171`