Skip to content

Commit 35dc0b0

Browse files
Colin Ian Kingmartinkpetersen
Colin Ian King
authored and
martinkpetersen
committed
scsi: isci: remove redundant check on in_connection_align_insertion_frequency
The sanity check on u->in_connection_align_insertion_frequency is being performed twice and hence the first check can be removed since it is redundant. Cleans up cppcheck warning: drivers/scsi/ibmvscsi/ibmvscsi.c:1711: (warning) Identical inner 'if' condition is always true. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 9407253 commit 35dc0b0

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

‎drivers/scsi/isci/init.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -433,9 +433,6 @@ static enum sci_status sci_user_parameters_set(struct isci_host *ihost,
433433
(u->max_speed_generation > SCIC_SDS_PARM_NO_SPEED)))
434434
return SCI_FAILURE_INVALID_PARAMETER_VALUE;
435435

436-
if (u->in_connection_align_insertion_frequency < 3)
437-
return SCI_FAILURE_INVALID_PARAMETER_VALUE;
438-
439436
if ((u->in_connection_align_insertion_frequency < 3) ||
440437
(u->align_insertion_frequency == 0) ||
441438
(u->notify_enable_spin_up_insertion_frequency == 0))

0 commit comments

Comments
 (0)