Skip to content

Commit 3790e39

Browse files
kleinermairlied
authored andcommitted
drm/tegra: Don't use vblank_disable_immediate on incapable driver.
Tegra would not only need a hardware vblank counter that increments at leading edge of vblank, but also support for instantaneous high precision vblank timestamp queries, ie. a proper implementation of dev->driver->get_vblank_timestamp(). Without these, there can be off-by-one errors during vblank disable/enable if the scanout is inside vblank at en/disable time, and additionally clients will never see any useable vblank timestamps when querying via drmWaitVblank ioctl. This would negatively affect swap scheduling under X11 and Wayland. Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com> Acked-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
1 parent 94754c1 commit 3790e39

File tree

1 file changed

+0
-1
lines changed
  • drivers/gpu/drm/tegra

1 file changed

+0
-1
lines changed

drivers/gpu/drm/tegra/drm.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ static int tegra_drm_load(struct drm_device *drm, unsigned long flags)
173173
drm->irq_enabled = true;
174174

175175
/* syncpoints are used for full 32-bit hardware VBLANK counters */
176-
drm->vblank_disable_immediate = true;
177176
drm->max_vblank_count = 0xffffffff;
178177

179178
err = drm_vblank_init(drm, drm->mode_config.num_crtc);

0 commit comments

Comments
 (0)