Skip to content

Commit 3816199

Browse files
koverstreetdchinner
authored andcommitted
block: add bio_iov_iter_get_pages()
This is a helper that pins down a range from an iov_iter and adds it to a bio without requiring a separate memory allocation for the page array. It will be used for upcoming direct I/O implementations for block devices and iomap based file systems. Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com> [hch: ported to the iov_iter interface, renamed and added comments. All blame should be directed to me and all fame should go to Kent after this!] Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@fb.com> (cherry picked from commit 9cd56d916aa481ce8f56d9c5302a6ed90c2e0b5f)
1 parent e3df41f commit 3816199

File tree

2 files changed

+50
-0
lines changed

2 files changed

+50
-0
lines changed

block/bio.c

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -847,6 +847,55 @@ int bio_add_page(struct bio *bio, struct page *page,
847847
}
848848
EXPORT_SYMBOL(bio_add_page);
849849

850+
/**
851+
* bio_iov_iter_get_pages - pin user or kernel pages and add them to a bio
852+
* @bio: bio to add pages to
853+
* @iter: iov iterator describing the region to be mapped
854+
*
855+
* Pins as many pages from *iter and appends them to @bio's bvec array. The
856+
* pages will have to be released using put_page() when done.
857+
*/
858+
int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter)
859+
{
860+
unsigned short nr_pages = bio->bi_max_vecs - bio->bi_vcnt;
861+
struct bio_vec *bv = bio->bi_io_vec + bio->bi_vcnt;
862+
struct page **pages = (struct page **)bv;
863+
size_t offset, diff;
864+
ssize_t size;
865+
866+
size = iov_iter_get_pages(iter, pages, LONG_MAX, nr_pages, &offset);
867+
if (unlikely(size <= 0))
868+
return size ? size : -EFAULT;
869+
nr_pages = (size + offset + PAGE_SIZE - 1) / PAGE_SIZE;
870+
871+
/*
872+
* Deep magic below: We need to walk the pinned pages backwards
873+
* because we are abusing the space allocated for the bio_vecs
874+
* for the page array. Because the bio_vecs are larger than the
875+
* page pointers by definition this will always work. But it also
876+
* means we can't use bio_add_page, so any changes to it's semantics
877+
* need to be reflected here as well.
878+
*/
879+
bio->bi_iter.bi_size += size;
880+
bio->bi_vcnt += nr_pages;
881+
882+
diff = (nr_pages * PAGE_SIZE - offset) - size;
883+
while (nr_pages--) {
884+
bv[nr_pages].bv_page = pages[nr_pages];
885+
bv[nr_pages].bv_len = PAGE_SIZE;
886+
bv[nr_pages].bv_offset = 0;
887+
}
888+
889+
bv[0].bv_offset += offset;
890+
bv[0].bv_len -= offset;
891+
if (diff)
892+
bv[bio->bi_vcnt - 1].bv_len -= diff;
893+
894+
iov_iter_advance(iter, size);
895+
return 0;
896+
}
897+
EXPORT_SYMBOL_GPL(bio_iov_iter_get_pages);
898+
850899
struct submit_bio_ret {
851900
struct completion event;
852901
int error;

include/linux/bio.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,7 @@ void bio_chain(struct bio *, struct bio *);
430430
extern int bio_add_page(struct bio *, struct page *, unsigned int,unsigned int);
431431
extern int bio_add_pc_page(struct request_queue *, struct bio *, struct page *,
432432
unsigned int, unsigned int);
433+
int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter);
433434
struct rq_map_data;
434435
extern struct bio *bio_map_user_iov(struct request_queue *,
435436
const struct iov_iter *, gfp_t);

0 commit comments

Comments
 (0)