Skip to content

Commit 3838f59

Browse files
committed
Revert "fbcon: bgcolor fix"
This reverts commit 2d04a4a, which made it impossible to make the softcursor use the highlight colors. Yes, the fourth bit should be "blinking", but since we cannot reasonably blink in fbcon, highlighting it with a bright background is preferable. Reported-by: Pavel Machek <pavel@suse.cz> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Cc: Krzysztof Helt <krzysztof.h1@poczta.fm> Cc: Antonino A. Daplas <adaplas@pol.net> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 4fbb715 commit 3838f59

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/video/console/fbcon.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ struct fbcon_ops {
9292
#define attr_fgcol(fgshift,s) \
9393
(((s) >> (fgshift)) & 0x0f)
9494
#define attr_bgcol(bgshift,s) \
95-
(((s) >> (bgshift)) & 0x07)
95+
(((s) >> (bgshift)) & 0x0f)
9696

9797
/* Monochrome */
9898
#define attr_bold(s) \

0 commit comments

Comments
 (0)