objtool: Remove "ANNOTATE_NOENDBR on ENDBR" warning

jpoimboe · Peter Zijlstra · commit 3c6f3900808c · 2022-08-19T19:47:57.000+02:00
This warning isn't very useful: why would you put ANNOTATE_NOENDBR on ENDBR, and if you did, what's the harm? And thus far it's only found one non-bug, where the '__end_entry_SYSENTER_compat' label happens to land on the ENDBR from entry_SYSCALL_compat: vmlinux.o: warning: objtool: entry_SYSCALL_compat+0x0: ANNOTATE_NOENDBR on ENDBR .. which is fine. Just remove the warning. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/142341a5dafdfc788e4c95b9e226a6eefc9b626e.1660839773.git.jpoimboe@kernel.org
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
@@ -2102,9 +2102,6 @@ static int read_noendbr_hints(struct objtool_file *file)
 			return -1;
 		}
 
-		if (insn->type == INSN_ENDBR)
-			WARN_FUNC("ANNOTATE_NOENDBR on ENDBR", insn->sec, insn->offset);
-
 		insn->noendbr = 1;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2102,9 +2102,6 @@ static int read_noendbr_hints(struct objtool_file *file)`
`2102`	`2102`	`return -1;`
`2103`	`2103`	`}`
`2104`	`2104`
`2105`		`- if (insn->type == INSN_ENDBR)`
`2106`		`- WARN_FUNC("ANNOTATE_NOENDBR on ENDBR", insn->sec, insn->offset);`
`2107`		`-`
`2108`	`2105`	`insn->noendbr = 1;`
`2109`	`2106`	`}`
`2110`	`2107`