scsi: qedi: Initialize the stats mutex lock

Nilesh Javali · martinkpetersen · commit 3cc5746e5ad7 · 2018-09-28T02:28:05.000-04:00
Fix kernel NULL pointer dereference,

Call Trace:
  [&lt;ffffffff9b7658e6&gt;] __mutex_lock_slowpath+0xa6/0x1d0
  [&lt;ffffffff9b764cef&gt;] mutex_lock+0x1f/0x2f
  [&lt;ffffffffc061b5e1&gt;] qedi_get_protocol_tlv_data+0x61/0x450 [qedi]
  [&lt;ffffffff9b1f9d8e&gt;] ? map_vm_area+0x2e/0x40
  [&lt;ffffffff9b1fc370&gt;] ? __vmalloc_node_range+0x170/0x280
  [&lt;ffffffffc0b81c3d&gt;] ? qed_mfw_process_tlv_req+0x27d/0xbd0 [qed]
  [&lt;ffffffffc0b6461b&gt;] qed_mfw_fill_tlv_data+0x4b/0xb0 [qed]
  [&lt;ffffffffc0b81c59&gt;] qed_mfw_process_tlv_req+0x299/0xbd0 [qed]
  [&lt;ffffffff9b02a59e&gt;] ? __switch_to+0xce/0x580
  [&lt;ffffffffc0b61e5b&gt;] qed_slowpath_task+0x5b/0x80 [qed]

Signed-off-by: Nilesh Javali &lt;nilesh.javali@cavium.com&gt;
Signed-off-by: Martin K. Petersen &lt;martin.petersen@oracle.com&gt;
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
@@ -2472,6 +2472,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
 		/* start qedi context */
 		spin_lock_init(&qedi->hba_lock);
 		spin_lock_init(&qedi->task_idx_lock);
+		mutex_init(&qedi->stats_lock);
 	}
 	qedi_ops->ll2->register_cb_ops(qedi->cdev, &qedi_ll2_cb_ops, qedi);
 	qedi_ops->ll2->start(qedi->cdev, &params);

Original file line number	Diff line number	Diff line change
`@@ -2472,6 +2472,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)`
`2472`	`2472`	`/* start qedi context */`
`2473`	`2473`	`spin_lock_init(&qedi->hba_lock);`
`2474`	`2474`	`spin_lock_init(&qedi->task_idx_lock);`
	`2475`	`+ mutex_init(&qedi->stats_lock);`
`2475`	`2476`	`}`
`2476`	`2477`	`qedi_ops->ll2->register_cb_ops(qedi->cdev, &qedi_ll2_cb_ops, qedi);`
`2477`	`2478`	`qedi_ops->ll2->start(qedi->cdev, &params);`