IB/cm: Fix device_create() return value check

Jani Nikula · Roland Dreier · commit 3e340c05c0de · 2010-03-31T14:26:52.000-07:00
Use IS_ERR() instead of comparing to NULL.

Signed-off-by: Jani Nikula &lt;ext-jani.1.nikula@nokia.com&gt;
Signed-off-by: Roland Dreier &lt;rolandd@cisco.com&gt;
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
@@ -3693,7 +3693,7 @@ static void cm_add_one(struct ib_device *ib_device)
 	cm_dev->device = device_create(&cm_class, &ib_device->dev,
 				       MKDEV(0, 0), NULL,
 				       "%s", ib_device->name);
-	if (!cm_dev->device) {
+	if (IS_ERR(cm_dev->device)) {
 		kfree(cm_dev);
 		return;
 	}

Original file line number	Diff line number	Diff line change
`@@ -3693,7 +3693,7 @@ static void cm_add_one(struct ib_device *ib_device)`
`3693`	`3693`	`cm_dev->device = device_create(&cm_class, &ib_device->dev,`
`3694`	`3694`	`MKDEV(0, 0), NULL,`
`3695`	`3695`	`"%s", ib_device->name);`
`3696`		`- if (!cm_dev->device) {`
	`3696`	`+ if (IS_ERR(cm_dev->device)) {`
`3697`	`3697`	`kfree(cm_dev);`
`3698`	`3698`	`return;`
`3699`	`3699`	`}`