efi/arm: preserve early mapping of UEFI memory map longer for BGRT

Ard Biesheuvel · wildea01 · commit 3ea86495aef2 · 2018-07-23T15:33:18.000+01:00
The BGRT code validates the contents of the table against the UEFI
memory map, and so it expects it to be mapped when the code runs.

On ARM, this is currently not the case, since we tear down the early
mapping after efi_init() completes, and only create the permanent
mapping in arm_enable_runtime_services(), which executes as an early
initcall, but still leaves a window where the UEFI memory map is not
mapped.

So move the call to efi_memmap_unmap() from efi_init() to
arm_enable_runtime_services().

Signed-off-by: Ard Biesheuvel &lt;ard.biesheuvel@linaro.org&gt;
[will: fold in EFI_MEMMAP attribute check from Ard]
Signed-off-by: Will Deacon &lt;will.deacon@arm.com&gt;
diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
@@ -259,7 +259,6 @@ void __init efi_init(void)
 
 	reserve_regions();
 	efi_esrt_init();
-	efi_memmap_unmap();
 
 	memblock_reserve(params.mmap & PAGE_MASK,
 			 PAGE_ALIGN(params.mmap_size +
diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
@@ -110,11 +110,13 @@ static int __init arm_enable_runtime_services(void)
 {
 	u64 mapsize;
 
-	if (!efi_enabled(EFI_BOOT)) {
+	if (!efi_enabled(EFI_BOOT) || !efi_enabled(EFI_MEMMAP)) {
 		pr_info("EFI services will not be available.\n");
 		return 0;
 	}
 
+	efi_memmap_unmap();
+
 	if (efi_runtime_disabled()) {
 		pr_info("EFI runtime services will be disabled.\n");
 		return 0;

Original file line number	Diff line number	Diff line change
`@@ -110,11 +110,13 @@ static int __init arm_enable_runtime_services(void)`
`110`	`110`	`{`
`111`	`111`	`u64 mapsize;`
`112`	`112`
`113`		`- if (!efi_enabled(EFI_BOOT)) {`
	`113`	`+ if (!efi_enabled(EFI_BOOT) \|\| !efi_enabled(EFI_MEMMAP)) {`
`114`	`114`	`pr_info("EFI services will not be available.\n");`
`115`	`115`	`return 0;`
`116`	`116`	`}`
`117`	`117`
	`118`	`+ efi_memmap_unmap();`
	`119`	`+`
`118`	`120`	`if (efi_runtime_disabled()) {`
`119`	`121`	`pr_info("EFI runtime services will be disabled.\n");`
`120`	`122`	`return 0;`