Skip to content

Commit 3f3a469

Browse files
andy-shevgregkh
authored andcommitted
serial: 8250_lpss: set PCI master only for private DMA
There is no need to set PCI bus mastering when device is not doing any DMA. Though on Intel Quark DMA is a part of UART IP and thus shares same device in Linux kernel. Enable bus mastering only for Quark case. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 0fe0764 commit 3f3a469

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/tty/serial/8250/8250_lpss.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,8 @@ static void qrk_serial_setup_dma(struct lpss8250 *lpss, struct uart_port *port)
183183
if (ret)
184184
return;
185185

186+
pci_set_master(pdev);
187+
186188
/* Special DMA address for UART */
187189
dma->rx_dma_addr = 0xfffff000;
188190
dma->tx_dma_addr = 0xfffff000;
@@ -280,8 +282,6 @@ static int lpss8250_probe(struct pci_dev *pdev, const struct pci_device_id *id)
280282
if (ret)
281283
return ret;
282284

283-
pci_set_master(pdev);
284-
285285
lpss = devm_kzalloc(&pdev->dev, sizeof(*lpss), GFP_KERNEL);
286286
if (!lpss)
287287
return -ENOMEM;

0 commit comments

Comments
 (0)