LSM: Don't ignore initialization failures

kees · James Morris · commit 3f6caaf5ff33 · 2018-10-10T20:40:22.000-07:00
LSM initialization failures have traditionally been ignored. We should
at least WARN when something goes wrong.

Signed-off-by: Kees Cook &lt;keescook@chromium.org&gt;
Reviewed-by: Casey Schaufler &lt;casey@schaufler-ca.com&gt;
Reviewed-by: John Johansen &lt;john.johansen@canonical.com&gt;
Signed-off-by: James Morris &lt;james.morris@microsoft.com&gt;
diff --git a/security/security.c b/security/security.c
@@ -55,10 +55,12 @@ static __initdata bool debug;
 static void __init major_lsm_init(void)
 {
 	struct lsm_info *lsm;
+	int ret;
 
 	for (lsm = __start_lsm_info; lsm < __end_lsm_info; lsm++) {
 		init_debug("initializing %s\n", lsm->name);
-		lsm->init();
+		ret = lsm->init();
+		WARN(ret, "%s failed to initialize: %d\n", lsm->name, ret);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -55,10 +55,12 @@ static __initdata bool debug;`
`55`	`55`	`static void __init major_lsm_init(void)`
`56`	`56`	`{`
`57`	`57`	`struct lsm_info *lsm;`
	`58`	`+ int ret;`
`58`	`59`
`59`	`60`	`for (lsm = __start_lsm_info; lsm < __end_lsm_info; lsm++) {`
`60`	`61`	`init_debug("initializing %s\n", lsm->name);`
`61`		`- lsm->init();`
	`62`	`+ ret = lsm->init();`
	`63`	`+ WARN(ret, "%s failed to initialize: %d\n", lsm->name, ret);`
`62`	`64`	`}`
`63`	`65`	`}`
`64`	`66`