Skip to content

Commit 3f7531c

Browse files
committed
drm/i915: Name the lrc irq handler correctly
We consistently use the _irq_handler postfix for functions called in hardirq context. Especially when it's a non-static function hardirq is a crazy enough calling context to warrant this level of ocd. So rename it. Cc: Thomas Daniel <thomas.daniel@intel.com> Reviewed-by: Thomas Daniel <thomas.daniel@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
1 parent 1a25205 commit 3f7531c

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

drivers/gpu/drm/i915/i915_irq.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1385,14 +1385,14 @@ static irqreturn_t gen8_gt_irq_handler(struct drm_device *dev,
13851385
if (rcs & GT_RENDER_USER_INTERRUPT)
13861386
notify_ring(dev, ring);
13871387
if (rcs & GT_CONTEXT_SWITCH_INTERRUPT)
1388-
intel_execlists_handle_ctx_events(ring);
1388+
intel_lrc_irq_handler(ring);
13891389

13901390
bcs = tmp >> GEN8_BCS_IRQ_SHIFT;
13911391
ring = &dev_priv->ring[BCS];
13921392
if (bcs & GT_RENDER_USER_INTERRUPT)
13931393
notify_ring(dev, ring);
13941394
if (bcs & GT_CONTEXT_SWITCH_INTERRUPT)
1395-
intel_execlists_handle_ctx_events(ring);
1395+
intel_lrc_irq_handler(ring);
13961396
} else
13971397
DRM_ERROR("The master control interrupt lied (GT0)!\n");
13981398
}
@@ -1408,14 +1408,14 @@ static irqreturn_t gen8_gt_irq_handler(struct drm_device *dev,
14081408
if (vcs & GT_RENDER_USER_INTERRUPT)
14091409
notify_ring(dev, ring);
14101410
if (vcs & GT_CONTEXT_SWITCH_INTERRUPT)
1411-
intel_execlists_handle_ctx_events(ring);
1411+
intel_lrc_irq_handler(ring);
14121412

14131413
vcs = tmp >> GEN8_VCS2_IRQ_SHIFT;
14141414
ring = &dev_priv->ring[VCS2];
14151415
if (vcs & GT_RENDER_USER_INTERRUPT)
14161416
notify_ring(dev, ring);
14171417
if (vcs & GT_CONTEXT_SWITCH_INTERRUPT)
1418-
intel_execlists_handle_ctx_events(ring);
1418+
intel_lrc_irq_handler(ring);
14191419
} else
14201420
DRM_ERROR("The master control interrupt lied (GT1)!\n");
14211421
}
@@ -1442,7 +1442,7 @@ static irqreturn_t gen8_gt_irq_handler(struct drm_device *dev,
14421442
if (vcs & GT_RENDER_USER_INTERRUPT)
14431443
notify_ring(dev, ring);
14441444
if (vcs & GT_CONTEXT_SWITCH_INTERRUPT)
1445-
intel_execlists_handle_ctx_events(ring);
1445+
intel_lrc_irq_handler(ring);
14461446
} else
14471447
DRM_ERROR("The master control interrupt lied (GT3)!\n");
14481448
}

drivers/gpu/drm/i915/intel_lrc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,13 +474,13 @@ static bool execlists_check_remove_request(struct intel_engine_cs *ring,
474474
}
475475

476476
/**
477-
* intel_execlists_handle_ctx_events() - handle Context Switch interrupts
477+
* intel_lrc_irq_handler() - handle Context Switch interrupts
478478
* @ring: Engine Command Streamer to handle.
479479
*
480480
* Check the unread Context Status Buffers and manage the submission of new
481481
* contexts to the ELSP accordingly.
482482
*/
483-
void intel_execlists_handle_ctx_events(struct intel_engine_cs *ring)
483+
void intel_lrc_irq_handler(struct intel_engine_cs *ring)
484484
{
485485
struct drm_i915_private *dev_priv = ring->dev->dev_private;
486486
u32 status_pointer;

drivers/gpu/drm/i915/intel_lrc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ struct intel_ctx_submit_request {
112112
int elsp_submitted;
113113
};
114114

115-
void intel_execlists_handle_ctx_events(struct intel_engine_cs *ring);
115+
void intel_lrc_irq_handler(struct intel_engine_cs *ring);
116116
void intel_execlists_retire_requests(struct intel_engine_cs *ring);
117117

118118
#endif /* _INTEL_LRC_H_ */

0 commit comments

Comments
 (0)