[PATCH] hwmon: Off-by-one error in fscpos driver

Jean Delvare · Linus Torvalds · commit 3fd1bb9baa39 · 2005-08-26T16:31:46.000-07:00
Coverity uncovered an off-by-one error in the fscpos driver, in function
set_temp_reset(). Writing to the temp3_reset sysfs file will lead to an
array overrun, in turn causing an I2C write to a random register of the
FSC Poseidon chip. Additionally, writing to temp1_reset and temp2_reset
will not work as expected. The fix is straightforward.

Signed-off-by: Jean Delvare &lt;khali@linux-fr.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
diff --git a/drivers/hwmon/fscpos.c b/drivers/hwmon/fscpos.c
@@ -167,7 +167,7 @@ static ssize_t set_temp_reset(struct i2c_client *client, struct fscpos_data
 				"experience to the module author.\n");
 
 	/* Supported value: 2 (clears the status) */
-	fscpos_write_value(client, FSCPOS_REG_TEMP_STATE[nr], 2);
+	fscpos_write_value(client, FSCPOS_REG_TEMP_STATE[nr - 1], 2);
 	return count;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ static ssize_t set_temp_reset(struct i2c_client *client, struct fscpos_data`
`167`	`167`	`"experience to the module author.\n");`
`168`	`168`
`169`	`169`	`/* Supported value: 2 (clears the status) */`
`170`		`- fscpos_write_value(client, FSCPOS_REG_TEMP_STATE[nr], 2);`
	`170`	`+ fscpos_write_value(client, FSCPOS_REG_TEMP_STATE[nr - 1], 2);`
`171`	`171`	`return count;`
`172`	`172`	`}`
`173`	`173`