sched/deadline: Remove a redundant condition from task_woken_dl()

Xunlei Pang · Ingo Molnar · commit 3fe33bcdd358 · 2015-08-03T12:21:20.000+02:00
'p' has been already queued at this point, so "!task_running(rq, p)" and "p->nr_cpus_allowed > 1" imply that "has_pushable_dl_tasks(rq)" is true, so it can be removed. Signed-off-by: Xunlei Pang <pang.xunlei@linaro.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Steven Rostedt <rostedt@goodmis.org> Cc: Juri Lelli <juri.lelli@gmail.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/1435995563-3723-2-git-send-email-xlpang@126.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
@@ -1657,7 +1657,6 @@ static void task_woken_dl(struct rq *rq, struct task_struct *p)
 {
 	if (!task_running(rq, p) &&
 	    !test_tsk_need_resched(rq->curr) &&
-	    has_pushable_dl_tasks(rq) &&
 	    p->nr_cpus_allowed > 1 &&
 	    dl_task(rq->curr) &&
 	    (rq->curr->nr_cpus_allowed < 2 ||

Original file line number	Diff line number	Diff line change
`@@ -1657,7 +1657,6 @@ static void task_woken_dl(struct rq rq, struct task_struct p)`
`1657`	`1657`	`{`
`1658`	`1658`	`if (!task_running(rq, p) &&`
`1659`	`1659`	`!test_tsk_need_resched(rq->curr) &&`
`1660`		`- has_pushable_dl_tasks(rq) &&`
`1661`	`1660`	`p->nr_cpus_allowed > 1 &&`
`1662`	`1661`	`dl_task(rq->curr) &&`
`1663`	`1662`	`(rq->curr->nr_cpus_allowed < 2 \|\|`