Skip to content

Commit 40b13ca

Browse files
Victor KamenskyWolfram Sang
authored andcommitted
i2c: omap: raw read and write endian fix
All OMAP IP blocks expect LE data, but CPU may operate in BE mode. Need to use endian neutral functions to read/write h/w registers. I.e instead of __raw_read[lw] and __raw_write[lw] functions code need to use read[lw]_relaxed and write[lw]_relaxed functions. If the first simply reads/writes register, the second will byteswap it if host operates in BE mode. Changes are trivial sed like replacement of __raw_xxx functions with xxx_relaxed variant. Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
1 parent c2a3a61 commit 40b13ca

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/i2c/busses/i2c-omap.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -266,13 +266,13 @@ static const u8 reg_map_ip_v2[] = {
266266
static inline void omap_i2c_write_reg(struct omap_i2c_dev *i2c_dev,
267267
int reg, u16 val)
268268
{
269-
__raw_writew(val, i2c_dev->base +
269+
writew_relaxed(val, i2c_dev->base +
270270
(i2c_dev->regs[reg] << i2c_dev->reg_shift));
271271
}
272272

273273
static inline u16 omap_i2c_read_reg(struct omap_i2c_dev *i2c_dev, int reg)
274274
{
275-
return __raw_readw(i2c_dev->base +
275+
return readw_relaxed(i2c_dev->base +
276276
(i2c_dev->regs[reg] << i2c_dev->reg_shift));
277277
}
278278

@@ -1140,9 +1140,9 @@ omap_i2c_probe(struct platform_device *pdev)
11401140
* Read the Rev hi bit-[15:14] ie scheme this is 1 indicates ver2.
11411141
* On omap1/3/2 Offset 4 is IE Reg the bit [15:14] is 0 at reset.
11421142
* Also since the omap_i2c_read_reg uses reg_map_ip_* a
1143-
* raw_readw is done.
1143+
* readw_relaxed is done.
11441144
*/
1145-
rev = __raw_readw(dev->base + 0x04);
1145+
rev = readw_relaxed(dev->base + 0x04);
11461146

11471147
dev->scheme = OMAP_I2C_SCHEME(rev);
11481148
switch (dev->scheme) {

0 commit comments

Comments
 (0)