checkpatch: improve "no space necessary after cast" test

JoePerches · torvalds · commit 43f7fe52a82e · 2015-02-13T21:21:40.000-08:00
Code like:
	if (a &lt; sizeof(&lt;type&gt;) &amp;&amp;
and
	{ .len = sizeof(&lt;type&gt;) },

incorrectly emits that warning, so add more exceptions to avoid
the warning.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
@@ -2541,7 +2541,7 @@ sub process {
 			}
 		}
 
-		if ($line =~ /^\+.*(\w+\s*)?\(\s*$Type\s*\)[ \t]+(?!$Assignment|$Arithmetic|[,;\({\[\<\>])/ &&
+		if ($line =~ /^\+.*(\w+\s*)?\(\s*$Type\s*\)[ \t]+(?!$Assignment|$Arithmetic|[,;:\?\(\{\}\[\<\>]|&&|\|\||\\$)/ &&
 		    (!defined($1) || $1 !~ /sizeof\s*/)) {
 			if (CHK("SPACING",
 				"No space is necessary after a cast\n" . $herecurr) &&

Original file line number	Diff line number	Diff line change
`@@ -2541,7 +2541,7 @@ sub process {`
`2541`	`2541`	`}`
`2542`	`2542`	`}`
`2543`	`2543`
`2544`		`- if ($line =~ /^\+.(\w+\s)?\(\s$Type\s\)[ \t]+(?!$Assignment\|$Arithmetic\|[,;\({\[\<\>])/ &&`
	`2544`	`+ if ($line =~ /^\+.(\w+\s)?\(\s$Type\s\)[ \t]+(?!$Assignment\|$Arithmetic\|[,;:\?\(\{\}\[\<\>]\|&&\|\\|\\|\|\\$)/ &&`
`2545`	`2545`	`(!defined($1) \|\| $1 !~ /sizeof\s*/)) {`
`2546`	`2546`	`if (CHK("SPACING",`
`2547`	`2547`	`"No space is necessary after a cast\n" . $herecurr) &&`