Skip to content

Commit 44e4925

Browse files
David GrahamJeff Garzik
authored andcommitted
e100: Fix Tyan motherboard e100 not receiving IPMI commands
The 82550 & 51 parts have an extended configuration block that includes a bit "GMRC", required to enable the expected TCO behavior, in config byte offset 22d. The config block sent by the failing driver does include the extension area, but this bit is not initialised, and the downlaod only specifies 0x16 bytes to be sent to the NIC (thaht's bytes 00..21d). By initializing the GMRC bit, and extending the download size for D102+ MACs, the problem is resolved. Signed-off-by: David Graham <david.graham@intel.com> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
1 parent c6f5047 commit 44e4925

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

drivers/net/e100.c

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@
159159

160160
#define DRV_NAME "e100"
161161
#define DRV_EXT "-NAPI"
162-
#define DRV_VERSION "3.5.17-k4"DRV_EXT
162+
#define DRV_VERSION "3.5.23-k4"DRV_EXT
163163
#define DRV_DESCRIPTION "Intel(R) PRO/100 Network Driver"
164164
#define DRV_COPYRIGHT "Copyright(c) 1999-2006 Intel Corporation"
165165
#define PFX DRV_NAME ": "
@@ -1024,10 +1024,16 @@ static void e100_configure(struct nic *nic, struct cb *cb, struct sk_buff *skb)
10241024
config->mwi_enable = 0x1; /* 1=enable, 0=disable */
10251025
config->standard_tcb = 0x0; /* 1=standard, 0=extended */
10261026
config->rx_long_ok = 0x1; /* 1=VLANs ok, 0=standard */
1027-
if(nic->mac >= mac_82559_D101M)
1027+
if (nic->mac >= mac_82559_D101M) {
10281028
config->tno_intr = 0x1; /* TCO stats enable */
1029-
else
1029+
/* Enable TCO in extended config */
1030+
if (nic->mac >= mac_82551_10) {
1031+
config->byte_count = 0x20; /* extended bytes */
1032+
config->rx_d102_mode = 0x1; /* GMRC for TCO */
1033+
}
1034+
} else {
10301035
config->standard_stat_counter = 0x0;
1036+
}
10311037
}
10321038

10331039
DPRINTK(HW, DEBUG, "[00-07]=%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X\n",

0 commit comments

Comments
 (0)