pinctrl: ocelot: fix gpio direction

alexandrebelloni · linusw · commit 44edff1bbc48 · 2018-03-26T11:04:48.000+02:00
Bits have to be cleared in DEVCPU_GCB:GPIO:GPIO_OE for input and set for
output. ocelot_gpio_set_direction() got it wrong and this went unnoticed
when the driver was reworked.

Reported-by: Gregory Clement &lt;gregory.clement@bootlin.com&gt;
Signed-off-by: Alexandre Belloni &lt;alexandre.belloni@bootlin.com&gt;
Acked-by: Gregory CLEMENT &lt;gregory.clement@bootlin.com&gt;
Signed-off-by: Linus Walleij &lt;linus.walleij@linaro.org&gt;
diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
@@ -252,7 +252,7 @@ static int ocelot_gpio_set_direction(struct pinctrl_dev *pctldev,
 	struct ocelot_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);
 
 	regmap_update_bits(info->map, OCELOT_GPIO_OE, BIT(pin),
-			   input ? BIT(pin) : 0);
+			   input ? 0 : BIT(pin));
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ static int ocelot_gpio_set_direction(struct pinctrl_dev *pctldev,`
`252`	`252`	`struct ocelot_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);`
`253`	`253`
`254`	`254`	`regmap_update_bits(info->map, OCELOT_GPIO_OE, BIT(pin),`
`255`		`- input ? BIT(pin) : 0);`
	`255`	`+ input ? 0 : BIT(pin));`
`256`	`256`
`257`	`257`	`return 0;`
`258`	`258`	`}`